SNOW-3488564: Remove Python 3.9#4218
Conversation
sfc-gh-joshi
requested review from
sfc-gh-aalam,
sfc-gh-bkogan,
sfc-gh-helmeleegy,
sfc-gh-jdu and
sfc-gh-jkew
sfc-gh-joshi
force-pushed
the
joshi-SNOW-3488564-py39-decommission
branch
from
7cae338 to
f6a08a3
Compare
sfc-gh-joshi
added
NO-CHANGELOG-UPDATES
sfc-gh-mayliu
left a comment
sfc-gh-mayliu
left a comment
There was a problem hiding this comment.
Snowpark-python specific python3.9 decommission changes look good; a few other places might also need updates. Another place I found is ReleaseSnowparkPythonPackageJob.groovy default release params still include 3.9. Can we drop that here too so the release job matches the supported matrix?
| @@ -1,5 +1,4 @@ | |||
| # Used internally by AnacondaPackageBuilder jobs | |||
| conda build recipe/ -c sfe1ed40 --python=3.9 --numpy=1.19 | |||
There was a problem hiding this comment.
conda builds look right to drop 3.9. Do we need the matching Jenkins packaging update too? jenkins_utils' Snowpark BuildAnaconda.groovy still shells out with --python=3.9`, so shall we sync that as well?
There was a problem hiding this comment.
conda builds look right to drop 3.9. Do we need the matching Jenkins packaging update too? jenkins_utils' Snowpark
BuildAnaconda.groovystill shells out with --python=3.9`, so shall we sync that as well?
That would make sense, but it looks like that file is also missing builds for 3.12, 3.13, and 3.14 entirely (which already exist in this repository's conda_build.sh). I'm not sure if that groovy file is still used anywhere.
|
It'd be great to trigger all relevant Jenkins jobs with this branch to monitor how Snowpark-python's 3.9 decommission impact downstream Jenkins builds. We could leverage this target: https://snowpark-python-001.jenkinsdev1.us-west-2.aws-dev.app.snowflake.com/job/SnowparkPythonReleaseValidationTrigger/ |
|
I just kicked off a release validation run: https://snowpark-python-001.jenkinsdev1.us-west-2.aws-dev.app.snowflake.com/job/SnowparkPythonReleaseValidationTrigger/83/
It looks like this job was last run almost a year ago, do we know who's using it? https://snowpark-python-001.jenkinsdev1.us-west-2.aws-dev.app.snowflake.com/job/ArtifactRepository/job/ReleaseSnowparkPythonPackageJob/ |
sfc-gh-joshi
force-pushed
the
joshi-SNOW-3488564-py39-decommission
branch
from
68df29a to
bb1d7e4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4218 +/- ##
==========================================
+ Coverage 95.38% 95.48% +0.09%
==========================================
Files 171 171
Lines 44243 44175 -68
Branches 7557 7532 -25
==========================================
- Hits 42203 42180 -23
+ Misses 1252 1231 -21
+ Partials 788 764 -24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sfc-gh-tycole
left a comment
sfc-gh-tycole
left a comment
There was a problem hiding this comment.
Decomm server side was paused and would begin next week - but testing changes LGTM.
| if major_version == 3 and minor_version < 9: | ||
| # Remove the `to_snowpark_pandas` test since Snowpark pandas is only supported in Python 3.9+. | ||
| if major_version == 3 and minor_version < 10: | ||
| # Remove the `to_snowpark_pandas` test since Snowpark pandas is only supported in Python 3.10+. |
There was a problem hiding this comment.
Yes. This check was technically already out-dated: the Snowpark pandas feature only supports pandas versions 2.2 and 2.3, which don't support Python 3.9.
6 participants
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-3488564
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Removes support for Python 3.9, adjusting import guards/test skips as needed. Tox environments and github actions jobs that previously used 3.9 have been bumped to 3.10 or removed.